build(deps): remove unecessary replace main go.mod #2675

julienrbrt · 2025-09-17T17:30:12Z

This PR was blocked but got merged: #2638.
It isn't bad to merge it, but we are relying on a fork of go-header for the apps until celestiaorg/go-header#347 is merged.
Let's delete it in the main go.mod

gemini-code-assist

Summary of Changes

Hello @julienrbrt, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the project's dependency management by removing a previously necessary 'replace' directive in the 'go.mod' file. This change allows the project to directly utilize the official 'celestiaorg/go-header' module, simplifying the build configuration and reflecting the integration of upstream changes or the resolution of prior dependency conflicts.

Highlights

Dependency Management: Removed a temporary 'replace' directive in the 'go.mod' file for the 'github.com/celestiaorg/go-header' module.
Module Resolution: The project now directly uses the official 'github.com/celestiaorg/go-header' module at version 'v0.7.2', indicating that the temporary override is no longer needed.
Build System Clean-up: Cleaned up the 'go.sum' file by removing entries related to the temporary 'julienrbrt/go-header' fork and adding entries for the official 'celestiaorg/go-header' module.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

github-actions · 2025-09-17T17:30:52Z

The latest Buf updates on your PR. Results from workflow CI and Release / buf-check (pull_request).

Build	Format	Lint	Breaking	Updated (UTC)
`✅ passed`	`⏩ skipped`	`✅ passed`	`✅ passed`	Sep 17, 2025, 5:30 PM

gemini-code-assist

Code Review

This pull request correctly removes a temporary replace directive from the go.mod file that was pointing to a fork of go-header. This is a good dependency hygiene practice, and the corresponding changes in go.sum are also correct. The change is approved. As a minor note, the word 'unnecessary' is misspelled in the pull request title.

claude · 2025-09-17T17:32:36Z

Code Review

Thank you for this cleanup PR! I've reviewed the changes and here's my feedback:

✅ Summary

This PR removes a temporary replace directive for github.com/celestiaorg/go-header that was pointing to a fork. The change updates to use the official v0.7.2 release directly.

Code Quality & Best Practices ✅

Good: Removing temporary replace directives improves maintainability and follows Go module best practices
Good: The PR correctly updates both go.mod and go.sum files
Good: The change aligns with the TODO comment indicating this was meant to be temporary

Potential Issues ⚠️

The referenced PR (feat: Add DeleteRange method to Store celestiaorg/go-header#347) appears to still be open and not merged. Please verify that v0.7.2 includes all the necessary functionality that was previously provided by the fork
Consider adding a comment in the PR description explaining why this replace is no longer necessary (e.g., if the required changes were merged in a different PR or if v0.7.2 already includes the needed features)

Performance Considerations ✅

No performance impact expected from this dependency management change

Security Concerns ✅

Using official releases instead of forks is generally better for security and maintenance
The change reduces supply chain risk by removing dependency on a personal fork

Test Coverage ✅

This is a dependency management change that doesn't require new tests
Existing tests should verify that functionality remains intact

Recommendations

Verify functionality: Please confirm that the official v0.7.2 release includes all necessary features that were in the fork
Update PR description: Add context about why this replace is no longer needed
CI validation: Ensure all CI checks pass with this change

Overall, this is a good cleanup that improves the project's dependency management. Just needs clarification on the timing given the referenced PR is still open.

codecov · 2025-09-17T17:33:01Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.57%. Comparing base (ec0a74a) to head (8cf744e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2675   +/-   ##
=======================================
  Coverage   66.57%   66.57%           
=======================================
  Files          76       76           
  Lines        7658     7658           
=======================================
  Hits         5098     5098           
  Misses       2093     2093           
  Partials      467      467

Flag	Coverage Δ
combined	`66.57% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

claude · 2025-09-17T19:23:06Z

🔍 Code Review

Summary

This PR removes an unnecessary replace directive from the main go.mod file that was previously blocking PR #2638. The change is straightforward and aligns with cleaning up technical debt.

✅ Strengths

Clean removal of temporary workaround
Properly updates go.sum to use the official github.com/celestiaorg/go-header v0.7.2
Follows good practice of removing unnecessary replace directives once upstream changes are available

⚠️ Issues Found

Inconsistent Replace Directives Across Modules

The main go.mod removes the replace directive for github.com/celestiaorg/go-header

However, ./apps/testapp/go.mod still contains the same replace directive:

replace github.com/celestiaorg/go-header => github.com/julienrbrt/go-header v0.0.0-20250909151551-cb11b091bf58

This inconsistency could lead to different versions being used in different parts of the codebase

🔧 Recommendations

Remove the replace directive from all modules: The replace directive should also be removed from ./apps/testapp/go.mod to maintain consistency across the codebase.
Verify upstream PR status: Please confirm that feat: Add DeleteRange method to Store celestiaorg/go-header#347 has been merged and the required functionality is available in v0.7.2 before removing all replace directives.
Run integration tests: After removing the replace directives, ensure all tests pass with:
```
make test-all
```

🔒 Security Considerations

No security concerns identified with this change

🧪 Test Coverage

This change doesn't require new tests as it's a dependency management update
Existing tests should validate that the official version works correctly

⚡ Performance Considerations

No performance impact expected from this dependency change

Conclusion

The PR is on the right track but needs to address the inconsistency across all go.mod files in the repository. Once the replace directive is removed from ./apps/testapp/go.mod as well, this change will be ready to merge.

build(deps): remove unecessary replace main go.mod

8cf744e

github-project-automation bot added this to Evolve Sep 17, 2025

github-actions bot assigned julienrbrt Sep 17, 2025

gemini-code-assist bot reviewed Sep 17, 2025

View reviewed changes

julienrbrt requested a review from tac0turtle September 17, 2025 19:20

julienrbrt enabled auto-merge September 17, 2025 19:20

tac0turtle approved these changes Sep 17, 2025

View reviewed changes

julienrbrt added this pull request to the merge queue Sep 17, 2025

Merged via the queue into main with commit 3b74069 Sep 17, 2025
34 of 36 checks passed

julienrbrt deleted the julien/remove-replace branch September 17, 2025 20:34

github-project-automation bot moved this to Done in Evolve Sep 17, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

build(deps): remove unecessary replace main go.mod #2675

build(deps): remove unecessary replace main go.mod #2675

Uh oh!

julienrbrt commented Sep 17, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

github-actions bot commented Sep 17, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

claude bot commented Sep 17, 2025

Uh oh!

codecov bot commented Sep 17, 2025 •

edited

Loading

Uh oh!

claude bot commented Sep 17, 2025

Uh oh!

Uh oh!

Uh oh!

build(deps): remove unecessary replace main go.mod #2675

build(deps): remove unecessary replace main go.mod #2675

Uh oh!

Conversation

julienrbrt commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

github-actions bot commented Sep 17, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

claude bot commented Sep 17, 2025

Code Review

✅ Summary

Code Quality & Best Practices ✅

Potential Issues ⚠️

Performance Considerations ✅

Security Concerns ✅

Test Coverage ✅

Recommendations

Uh oh!

codecov bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

claude bot commented Sep 17, 2025

🔍 Code Review

Summary

✅ Strengths

⚠️ Issues Found

🔧 Recommendations

🔒 Security Considerations

🧪 Test Coverage

⚡ Performance Considerations

Conclusion

Uh oh!

Uh oh!

Uh oh!

julienrbrt commented Sep 17, 2025 •

edited

Loading

codecov bot commented Sep 17, 2025 •

edited

Loading